fix(mount): avoid warning when stubbing #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we "properly" register stubs (see this commit vuejs@bb8023f), a bunch of warning are logged by Vue when a test tries to stub an already registered component. For example, vue-router-mock register RouterView and then stubs it (see https://github.com/posva/vue-router-mock/blob/v2/src/injections.ts#L37-L41). So if you use vue-router-mock (or a similar pattern) in your test, Vue logs: [Vue warn]: Component "RouterView" has already been registered in target app. because when a component is stubbed, we re-register it in VTU-next, and Vue warns us that it might be a mistake. This is a quite naive fix, as it removes the already registered component before registering the stub.
|
Superseeded by #504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we "properly" register stubs
(see this commit bb8023f),
a bunch of warning are logged by Vue when a test tries to stub an already registered component.
For example, vue-router-mock register RouterView and then stubs it
(see https://github.com/posva/vue-router-mock/blob/v2/src/injections.ts#L37-L41).
So if you use vue-router-mock (or a similar pattern) in your test, Vue logs:
because when a component is stubbed, we re-register it in VTU-next, and Vue warns us that it might be a mistake.
This is a quite naive fix, as it removes the already registered component before registering the stub.